-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Gitpod #866
Conversation
For the documentation stuff, maybe it should be on contributing docs, which I'll write soon. |
a097d6c
to
9bc0751
Compare
I just do a |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
834752a
to
9797715
Compare
Just rebased against the latest commits from the |
470e32a
to
cff1ee6
Compare
Rebased again against |
@ajhalili2006 Do you manually write the gitpod Dockerfile ? If yes, I strongly suggest to automate it, else it will be too long to maintain (all Dockerfiles content are coming from descriptors and generated using build.py If you want I can manage the automation later, but please at least keep the comments I use for replacements :) (#NPM__START, #NPM__END, #PIP__START, #PIP__END, etc .... :) ) Or if the images are similar, maybe you could base your dockerfile on |
Codecov Report
@@ Coverage Diff @@
## main #866 +/- ##
==========================================
+ Coverage 87.71% 87.74% +0.03%
==========================================
Files 138 138
Lines 3328 3328
==========================================
+ Hits 2919 2920 +1
+ Misses 409 408 -1
Continue to review full report at Codecov.
|
I tried using the main Dockerfile in a test GitLab repo, and it's failed with the following error:
Maybe because its assume that the base image is Debian-based and reproducing some parts of So maybe I'll rewrite the Gitpod Dockerfile to include only the required Python packages within the repo, and the rest maybe run as part of the container using the main Dockerfile. Footnotes |
Also on workspace init, it'll pull the latest builds from Docker Hub. May expect some weird pull issues. Signed-off-by: Andrei Jiroh Eugenio Halili <[email protected]>
fadac54
to
9186e3f
Compare
Since I force pushed stuff with lease, old commits can be found at https://github.com/ajhalili2006/mega-linter/tree/old-draft/gitpodify-repo branch. |
Still draft ? :) |
Hey @nvuillam, Sorry for the long wait. I'm going to rebase the branch later to ensure its in sync with the main branch. |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
Proposed Changes
.gitpod.yml
to automatically configure Git to setcore.autocrlf
to true and installs extensions from Open VSX that are recommended by the project..vscode/extensions#recommendations
to.gitpod.yml#vscode.extensions
Roadblockers in adding Gitpod support
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance